Replaced SpinBox nodes with EditorSpinSlider nodes for better Snap Config - #37998
Closed
elijahscherz wants to merge 1 commit into
Closed
Replaced SpinBox nodes with EditorSpinSlider nodes for better Snap Config#37998elijahscherz wants to merge 1 commit into
elijahscherz wants to merge 1 commit into
Conversation
Member
Nah, EditorSpinSlider can be used anywhere in the editor. There is even an idea to expose it like a regular control, because it's useful. Anyways, the new dialog seems bigger than necessary. I mean, you don't need such wide inputs for grid, where values are almost never going to exceed 1000. Also units outside inputs aren't a good idea. They should stay inside. Like in Node2D for example: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working towards Snap Config dialog box improvements requested in #13966.
The main idea is replacing the
SpinBoxnodes withEditorSpinSlidernodes to allow drag setting and a nicer interface.Previous -
After changes -
However, I anticipate needing to make adjustments for this solution. This currently uses
EditorSpinSlidernodes, but does not have an EditorInspector associated with it, which seems like it might be a misuse of the node. (Though it does seem to function and sets the config values.)I will happily make changes to this, but just need a small example code snippet showing how I could more properly network the slider nodes.